Repository navigation
feat(py-client)!: Remove deprecated compression argument from Session.put - #718
Merged
Merged
Conversation
….put Co-Authored-By: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 91.81% 91.81% -0.01%
==========================================
Files 116 116
Lines 24065 24060 -5
==========================================
- Hits 22095 22090 -5
Misses 1970 1970
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
marked this pull request as ready for review
October 22, 2026 10:34
lcian
approved these changes
Oct 22, 2026
jan-auer
approved these changes
Oct 22, 2026
jan-auer
enabled auto-merge (squash)
October 22, 2026 12:06
jan-auer
disabled auto-merge
October 22, 2026 12:06
jan-auer
added a commit
that referenced
this pull request
Oct 22, 2026
#718 removed the deprecated `compression` argument from `Session.put` and with it the only use of `warnings` in `client.py`. The leftover import fails `ruff check` (F401) in the Lint Python job on main. Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: async jauer <jan.auer@sentry.io>
Semver Impact of This PR🔴 Major (breaking changes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠Py Client
Rs Client
New Features ✨
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
compressionargument fromSession.put()session.put(..., compression=...)withsession.put(..., compress=...).Details
Breaking change for the Python client.
Session.put(compression=...)was deprecated in #586 in favor ofcompress. This removes the argument, itsDeprecationWarning, and the check against passing both.It also deletes
test_compression_argument_is_deprecated. #586 added that test specifically for the deprecated path: it asserts theDeprecationWarningand theValueErrorwhen both arguments are passed. Neither applies anymore. Its uncompressed round trip throughcompress="none"is already covered bytest_full_cycle_uncompressedandtest_full_cycle_with_origin, so renaming the argument in the test would only duplicate them.via @lcian.
--
View Junior Session [Sentry]