Repository navigation
fix(statuspage): Keep affected components attached on incident updates - #418
Merged
Merged
Conversation
#279 only sent non-operational components in component_ids. When an update sets every component back to operational (e.g. resolve), the incident ends up with no affected components, so component subscribers stop receiving that update and any later ones, including the resolve. Union the incident's existing components with newly non-operational ones so recovered components stay attached to the incident. Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
spalmurray
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #279.
update_incidentonly puts non-operational components incomponent_ids. The Slack modal sends every component, so when an update sets all components back to operational (usually the resolve),component_idsgoes out as[]and Statuspage removes every component from the incident.Statuspage sends incident updates to component subscribers based on the incident's affected components (docs). Once none are left, component subscribers stop getting that update and every later one, even when they're subscribed to every component.
Evidence (#triage-incidents, subscriber = Slack subscription with all components checked)
qt0614n6hpn1"Sentry.io not loading": create, both updates and Monitoring all reached the subscriber while Dashboard/API were degraded. The resolve, sent with every component back to operational, never did.gbgxwj82brd4"Sentry is down": create and first update reached it. Then an update set every component to operational and moved the incident to Monitoring, and the subscriber missed that update, the next one and the resolve.gts1fg3r2j4b(create with components in major outage) was delivered normally.Fix
On update, fetch the incident and send
component_ids= its current components plus any newly non-operational components. Components that recover stay attached, the incident keeps showing what it affected, and subscribers still get the resolve.componentsstill carries every status, so resets to operational still apply.create_incidentis unchanged, since there's nothing to keep yet.Cost: one extra GET for each update that includes components.
Tests
uv run pytest src/firetower/integrations/tests/test_statuspage.pypasses: 25 tests, including 2 new ones for keeping existing components and adding new ones.slack_app/tests/handlers/test_statuspage.py, which needs Postgres that wasn't available locally (it mocksStatuspageServiceanyway).via Richard Gibert.
--
View Junior Session [Sentry]