Show the document title in the browser tab - #1795
Open
AnotherDork wants to merge 1 commit into
Open
Conversation
Every document tab rendered under the shared layout kept the static "Probo Console" title, so several open documents were indistinguishable in the browser tab strip. Set the page title from the current version's title, as the other detail pages already do. Signed-off-by: Gren Paut <90505696+AnotherDork@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every document tab rendered under
DocumentLayout(description, controls, approvals, signatures) kept the staticProbo Consoletitle fromindex.html, so several documents open at once are indistinguishable in the browser tab strip.DocumentLayoutnow calls the existingusePageTitlehook with the current version's title, matching what the risk, measure, third-party and campaign detail pages already do. The title comes from the version already loaded byDocumentLayoutQuery, so no extra request — justtitleadded to the twoDocumentVersionselections.Verified:
make relay,npm run check -w @probo/console,eslinton the changed file.Summary by cubic
Sets the browser tab title to the current document's title for every tab rendered under
DocumentLayout, so several open documents are no longer indistinguishable in the tab strip. The title comes from the version already loaded by the query, so no extra request is needed.App: console
+5-0usePageTitlewith the current version's title and addstitleto the twoDocumentVersionselections.Written for commit a4bf30d. Summary will update on new commits.