Drop unused reports table and leftovers - #1767
Merged
Merged
Conversation
SachaProbo
force-pushed
the
SachaProbo/drop-unused-reports-table
branch
from
August 24, 2026 14:15
3810804 to
7582800
Compare
SachaProbo
force-pushed
the
SachaProbo/drop-unused-reports-table
branch
from
August 28, 2026 15:07
7582800 to
034b598
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Audit PDFs already live in files via report_file_id. The reports table and leftover report_id foreign keys were never dropped after that migration. Signed-off-by: Sacha Al Himdani <sacha@probo.com>
SachaProbo
force-pushed
the
SachaProbo/drop-unused-reports-table
branch
from
August 28, 2026 16:06
034b598 to
c213349
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit PDFs already live in files via report_file_id. The reports table and leftover report_id foreign keys were never dropped after that migration.
Summary by cubic
Removes the unused reports domain by dropping the reports table and all report_id references. This consolidates audit PDFs on report_file_id and removes dead code; callers can no longer query by report_id.
Coredata
+41-116cp_document_accesses.report_id, tightens its CHECK to require exactly one ofdocument_id,report_file_id, orcompliance_portal_file_id, dropsaudits.report_id, and drops the reports table.Audits.LoadByReportIDsand theReportOrderFieldtype.report_file_id.Written for commit c213349. Summary will update on new commits.