Add Rippling access review support - #1748
Draft
gearnode wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./pkg/accessreview/drivers ./pkg/connector/provider ./pkg/coredata ./pkg/server/api/console/v1go test -race ./pkg/accessreview/drivers ./pkg/connector/providergo test -race -v ./pkg/accessreview/drivers -run 'TestRippling'go vet ./pkg/accessreview/drivers ./pkg/connector/provider ./pkg/coredata ./pkg/server/api/console/v1make go-fmtmake lintcannot complete in the cloud image becausegolangci-lintis not installed; the available targeted vet and formatting checks pass.Summary by cubic
Adds Rippling as an API‑token access review provider and adds the DB enum needed to store it. Lists Rippling users with safe cursor pagination and surfaces the provider in
coredataand the Console GraphQL enum.Tests
+165-0RipplingDriver./userspagination.Coredata
+25-1ConnectorProviderRipplingto the enum, provider list, andIsValid().connector_providertype withRIPPLING. Run migrations before creating Rippling connectors.GraphQL API
+2-0RIPPLINGto theConnectorProviderenum mapped tocoredata.ConnectorProviderRippling.Service
+276-0https://rest.ripplingapis.comand probehttps://rest.ripplingapis.com/users/.RipplingDriverto fetch/users, prefer WORK emails, derive full name, setMFAStatusUnknownandAccountTypeUser, parsecreated_at, and follownext_linkonly on the same host; returns errors on non‑2xx without leaking response bodies.Written for commit 09a8bca. Summary will update on new commits.