Skip to content

feat: add Front connector support - #1695

Open
Steven4Hooisma wants to merge 5 commits into
getprobo:mainfrom
Steven4Hooisma:front_access_review
Open

feat: add Front connector support#1695
Steven4Hooisma wants to merge 5 commits into
getprobo:mainfrom
Steven4Hooisma:front_access_review

Conversation

@Steven4Hooisma

@Steven4Hooisma Steven4Hooisma commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
  • OAuth and API key authorization
  • will retrieve all teammates /teammates

Summary by cubic

Adds a Front connector for access reviews. Previously we did not support Front; now we fetch all teammates via Front’s Core API, classify admins and service accounts, and surface FRONT across APIs and UI. This adds a DB enum value and new env vars for OAuth; the builder now requires CLIENT_SECRET for FRONT.

Tests +398 -1

  • Cover FrontDriver mapping, pagination guard (including cross-host refusal), and context cancellation.
  • Verify name resolver and provider wiring; assert token exchange mode and API key support.
  • Add cassette fixture pkg/accessreview/drivers/testdata/front.yaml.

Coredata +24 -0

  • Add FRONT to ConnectorProvider and migration 20260812T090000Z.sql.

GraphQL API +1 -0

  • Expose FRONT in connector.graphql enum.

Service +458 -0

  • Implement FrontDriver to list /teammates, label admins, detect service accounts by type, and page safely with same-host enforcement.
  • Add frontNameResolver using /me and reuse the protected HTTP client.
  • Register provider with OAuth (basic-form token exchange, no per-request scopes) and API key; probe /me, set APIBase to https://api2.frontapp.com.
  • Bootstrap PROBOD_CONNECTOR_FRONT_* and require CLIENT_SECRET.

Package: ui +16 -0

  • Add Front logo SVG and register in ThirdPartyLogo.

Other +2 -0

  • Update .env.example with PROBOD_CONNECTOR_FRONT_CLIENT_ID and PROBOD_CONNECTOR_FRONT_CLIENT_SECRET.

Written for commit ed1d00f. Summary will update on new commits.

Review in cubic

- OAuth and API key authorization
- will retrieve all teammates  /teammates

Signed-off-by: Steven4Hooisma <112615049+Steven4Hooisma@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread pkg/accessreview/drivers/front.go
Signed-off-by: grootSH <112615049+Steven4Hooisma@users.noreply.github.com>
@Steven4Hooisma
Steven4Hooisma marked this pull request as draft August 12, 2026 09:28
@Steven4Hooisma

Steven4Hooisma commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

API Key is working fine.
OAuth flow will go to the correct authentication page, but the redirect is still throwing an error locally

@Steven4Hooisma
Steven4Hooisma marked this pull request as ready for review August 17, 2026 08:55

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread pkg/coredata/connector_provider.go Outdated
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Signed-off-by: grootSH <112615049+Steven4Hooisma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant