Link findings to third parties - #1619
Draft
gearnode wants to merge 1 commit into
Draft
Conversation
Persist finding-to-third-party associations so compliance findings can identify affected providers. Expose the relationship in both directions and add console views for managing and reviewing linked records. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make relaynpm --workspace @probo/console run checknpm --workspace @probo/n8n-nodes-probo run lintgo test ./pkg/coredata ./pkg/probo ./pkg/server/api/console/v1 ./pkg/server/api/mcp/v1 ./pkg/cmd/finding/updatemake go-fmtSummary by cubic
Adds many-to-many linking between findings and third parties. Includes UI to manage links, GraphQL support in both directions, and tool updates to set
thirdPartyIdsduring finding updates.Coredata
+232-0finding_third_partiestable and merge logic to upsert links.LoadByThirdPartyID/CountByThirdPartyIDfor findings.ThirdPartyFilterto filter by a linked finding.Service
+76-0UpdateFindingRequestnow acceptsThirdPartyIDswith validation and org checks.GraphQL API
+123-0thirdPartiesconnection.findingsconnection.UpdateFindingInputaddsthirdPartyIds; resolvers handle listing and total counts.App: console
+320-3ThirdPartiesMultiSelectFieldand i18n labels.prb (CLI)
+6-0--third-party-idflag; included in update payload when set.Package: n8n-node
+13-0thirdPartyIds.MCP
+6-1third_party_idsfor finding updates.Written for commit 4647034. Summary will update on new commits.