Skip to content

Link findings to third parties - #1619

Draft
gearnode wants to merge 1 commit into
mainfrom
cursor/link-findings-third-parties-78a2
Draft

Link findings to third parties#1619
gearnode wants to merge 1 commit into
mainfrom
cursor/link-findings-third-parties-78a2

Conversation

@gearnode

@gearnode gearnode commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • persist many-to-many links between findings and third parties
  • expose linked third parties on findings and linked findings on third parties
  • add finding management to the finding detail page and a paginated Findings tab to third-party details
  • support third-party IDs in MCP, CLI, and n8n finding updates

Testing

  • make relay
  • npm --workspace @probo/console run check
  • npm --workspace @probo/n8n-nodes-probo run lint
  • go test ./pkg/coredata ./pkg/probo ./pkg/server/api/console/v1 ./pkg/server/api/mcp/v1 ./pkg/cmd/finding/update
  • make go-fmt
Open in Web Open in Cursor 

Summary by cubic

Adds many-to-many linking between findings and third parties. Includes UI to manage links, GraphQL support in both directions, and tool updates to set thirdPartyIds during finding updates.

Coredata +232 -0

  • Added finding_third_parties table and merge logic to upsert links.
  • Implemented LoadByThirdPartyID/CountByThirdPartyID for findings.
  • Extended ThirdPartyFilter to filter by a linked finding.

Service +76 -0

  • UpdateFindingRequest now accepts ThirdPartyIDs with validation and org checks.
  • On update, merges link set for the finding.
  • Added listing/counting of findings for a third party.

GraphQL API +123 -0

  • Finding: new thirdParties connection.
  • ThirdParty: new findings connection.
  • UpdateFindingInput adds thirdPartyIds; resolvers handle listing and total counts.

App: console +320 -3

  • Finding details: added ThirdPartiesMultiSelectField and i18n labels.
  • Third party details: new “Findings” tab with paginated table and routes.
  • Added loader and list item components; updated locale strings.

prb (CLI) +6 -0

  • New repeatable --third-party-id flag; included in update payload when set.

Package: n8n-node +13 -0

  • Finding update supports “Third Party IDs” (comma-separated) mapped to thirdPartyIds.

MCP +6 -1

  • Update tool and spec now accept and forward third_party_ids for finding updates.

Written for commit 4647034. Summary will update on new commits.

Review in cubic

Persist finding-to-third-party associations so compliance findings can
identify affected providers. Expose the relationship in both directions
and add console views for managing and reviewing linked records.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants