Skip to content

Disable remove response for most tests#7248

Open
seadowg wants to merge 2 commits into
getodk:masterfrom
seadowg:long-press
Open

Disable remove response for most tests#7248
seadowg wants to merge 2 commits into
getodk:masterfrom
seadowg:long-press

Conversation

@seadowg
Copy link
Copy Markdown
Member

@seadowg seadowg commented Jun 2, 2026

This disables the long press context menu for widgets in tests other than the ones that interact with it. This menu causes a lot of flakes due to the accidental long press problem in Espresso. @lognaturel and I have discussed potentially moving the menu away from a long press as a general UX change in the future, so this just works around the problem for now.

@seadowg seadowg marked this pull request as ready for review June 2, 2026 14:09
@seadowg seadowg requested a review from grzesiek2010 June 2, 2026 14:09

public abstract class QuestionWidget extends FrameLayout implements Widget {

public static Boolean longPressClear = true;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gates the whole long-press menu (it also has "delete repeat group"), not just clearing answers - maybe longPressMenuEnabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants