Display images in the summary view#7234
Open
grzesiek2010 wants to merge 16 commits into
Open
Conversation
bcd10a8 to
bde4db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #6084
Closes #7168
Why is this the best possible solution? Were any other approaches considered?
The new
ImageWidgetAnswercomponent continues the approach we already introduced forvideoandfilequestions. Similar to those question types, I started refactoring the widgets so they can share the same answer component with the summary view.To avoid making this PR too large, I started with the basic image question. I decided not only to rework it to use the new
ImageWidgetAnswer, but also to shift frominheritancetocompositionby detaching it from its previous hierarchy. It previously extendedBaseImageWidget, which had become a fairly convoluted structure.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Images should be displayed in the summary view regardless of which image question type they come from (
image/draw/signature/annotate). The summary view should be tested with all image question types, but we don’t need to test each image question type in form entry. Only the basic image question has been refactored, so that is the one that requires thorough testing. Only the basic image question currently shares the new image component with the summary view, so only that question type will display images with rounded corners. We plan to apply the same approach to the other image question types in the future.Do we need any specific form for testing your changes? If so, please attach one.
The
All question typesforms should be enough.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest