test/nginx: extract request() and add testing#1955
Merged
Conversation
2 tasks
alxndrsn
commented
Jun 6, 2026
| it('should allow setting Host header', async () => { | ||
| // given | ||
| const headers = { | ||
| 'host': 'not-a-host', // FIXME also test with other cases, e.g. "Host" or "HOST" |
Contributor
Author
There was a problem hiding this comment.
Reviewer: this is a bug in request(), but I didn't want to change any functionality in this PR.
matthew-white
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added as a precursor to #1949.
What has been done to verify that this works as intended?
This does not change functional code, just adds a test for
request()and extracts that function to its own file.These tests can be seen to fail by substituting
fetch()forrequest():Why is this the best possible solution? Were any other approaches considered?
request()is quite complicated, and deserves tests before future changes.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect - just test code.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)