Skip to content

nginx: reject form previews with unexpected query params#1947

Merged
alxndrsn merged 4 commits into
getodk:nextfrom
alxndrsn:preview-strip-unexpected-query-params
Jun 5, 2026
Merged

nginx: reject form previews with unexpected query params#1947
alxndrsn merged 4 commits into
getodk:nextfrom
alxndrsn:preview-strip-unexpected-query-params

Conversation

@alxndrsn
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn commented Jun 4, 2026

What has been done to verify that this works as intended?

New tests, existing tests.

Why is this the best possible solution? Were any other approaches considered?

$args matching seems like a blunt implement, but nginx config is also quite limiting.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No expected effect.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn marked this pull request as ready for review June 4, 2026 14:45
Comment thread test/nginx/src/mocha/nginx.spec.js Outdated
Comment thread test/nginx/src/mocha/nginx.spec.js Outdated
@alxndrsn alxndrsn merged commit 18b9667 into getodk:next Jun 5, 2026
7 checks passed
@alxndrsn alxndrsn deleted the preview-strip-unexpected-query-params branch June 5, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants