nginx: specify nginx version#1937
Open
alxndrsn wants to merge 1 commit into
Open
Conversation
Member
|
I'm thinking that it makes sense for @sadiqkhoja to review this one, since he's the one who typically updates nginx (e.g., as part of #1805). |
lognaturel
reviewed
Jun 3, 2026
| # * https://hub.docker.com/r/jonasal/nginx-certbot/tags | ||
| # 2. Look for upstream changes to redirector.conf | ||
| # 3. Confirm setup-odk.sh strips out HTTP-01 ACME challenge location. | ||
| FROM jonasal/nginx-certbot:6.1.0-nginx1.29.7 |
Member
There was a problem hiding this comment.
Servers that have rebuilt recently would have been running -nginx1.31.1. I think we should go straight to that tag since some production users already have it.
Whoops, I see 6.2.0 straddles nginx 1.29 and 1.31 but 6.1.0 does not. So we could stay on 6.1.0 for now and this would be the correct pin. Then we could look at actually upgrading later based on what the latest version is at that time.
Member
|
@sadiqkhoja I added some notes at #1936 (comment) that you may find to be helpful context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1936
What has been done to verify that this works as intended?
✅ CI
Why is this the best possible solution? Were any other approaches considered?
Reduces nginx changes silently affecting production behaviour.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Reduces drift in nginx versions between same ODK Central versions. This should reduce risk.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
I don't think so.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)