[D1353L]

Context

Earlier steps in this stack added the structured payment_term to customers and billing entities, with the net_payment_term integer as a compatibility alias. This PR exposes it via the REST API. Before this change, clients could only send the integer.

Description

Write path

• payment_term is accepted on customer and billing entity create/update.
• PaymentTerms::ValidateService runs in all five write services before any persistence. Invalid input returns a validation error.
• The redundant direct net_payment_term column writes are removed. PaymentTerms::AssignService is now the only term write path.
• A new RawPaymentTermParams controller concern copies the raw payment_term and net_payment_term values into the permitted params. Without this concern, invalid input would be dropped silently instead of returning a validation error.
• PaymentTerms::ValidateService normalizes its input, so ActionController::Parameters and plain hashes give the same result.
• Behavior change: when both payment_term and net_payment_term are sent and disagree (e.g. {net, 30} with 60, or end_of_month with 0), the write is rejected with conflicting_net_payment_term on payment_term. Before, payment_term silently won. A null net_payment_term sent with a structured term, and an explicit payment_term: null, are still accepted.

Read path

• Added payment_term to customer and billing entity serializers.
• The invoice serializer returns the snapshotted payment_term. For invoices from before this feature, it builds {term_type: "net", days: N} from the invoice's own integer.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: HOLD · CI green

HOLD — structured payment-term support is incomplete across sibling APIs and still has invalid-input failure paths.

• Expose payment_term on the customer and billing-entity GraphQL object/input types and cover those paths. A non-net term written through V1 currently cannot be read or edited through the sibling GraphQL API; it appears there only as net_payment_term: null.
• Make raw-param preservation handle array-shaped wrong types recursively and add request coverage. In CustomersController, payment_term: [{term_type: "net"}] copies unpermitted nested parameters into permitted, so the subsequent to_h raises instead of returning the intended payment_term: ["invalid_format"] response.
• Apply payment_term precedence consistently during validation. The services validate net_payment_term even when payment_term is present, so an invalid legacy alias rejects a request that AssignService documents as ignoring because the structured term wins.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: HOLD · CI green

HOLD — Organizations::CreateService ignores the newly possible validation failure returned by BillingEntities::CreateService.

• Propagate that child failure and add a regression spec proving invalid payment-term input rolls back organization/API-key creation; currently the outer service reports success and commits an organization without its default billing entity.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: HOLD · CI green

HOLD — a structured customer term can make quotes announce different payment terms from the resulting invoices.

• app/services/quote_versions/compute_mention_variables_service.rb:29 still snapshots customer.applicable_net_payment_term. Non-net terms intentionally have a null alias (app/models/payment_term.rb:57), so Customer#applicable_net_payment_term falls back to the billing entity (app/models/customer.rb:269) even though invoice resolution prioritizes the customer's structured term (app/services/payment_terms/resolve_service.rb:14). Resolve and localize the structured term in the quote path, preserve existing integer snapshots, and add a regression spec for an explicit non-net customer term.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: HOLD · CI green

HOLD — the organization payment-term source is inconsistent across REST and GraphQL.

• app/serializers/v1/organization_serializer.rb:52 now sources net_payment_term from the default billing entity because direct billing-entity updates do not update the organization column, but app/graphql/types/organizations/current_organization_type.rb:25 still resolves Organization#net_payment_term. After such an update, GraphQL returns the stale integer while REST returns the billing entity's value. Resolve the GraphQL field from the default billing entity as well and add a behavioral spec; the current type spec only checks nullability.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: PASS · CI green

PASS — Structured payment terms are validated and synchronized across customer and billing-entity write paths, the legacy alias remains compatible, V1 reads expose the optional field without leaking it into V2 customer payloads, and the new behavior has focused request, service, resolver, and serializer coverage.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: HOLD · CI green

HOLD — malformed legacy payment-term input can silently clear an existing term.

• RawPaymentTermParams#with_raw_payment_term copies object/array values for net_payment_term into permitted params (app/controllers/concerns/raw_payment_term_params.rb:10), but PaymentTerms::ValidateService#valid? validates only payment_term (app/services/payment_terms/validate_service.rb:9). Rails casts those non-integer aliases to nil, and PaymentTerms::AssignService then mirrors nil into both columns (app/services/payment_terms/assign_service.rb:24), so customer upserts and billing-entity updates can return success while erasing the prior term. Validate the raw alias shape before assignment and add request coverage proving malformed object/array aliases return a validation error without changing either record.

[lago-claude-ai-agent]

Automated pre-review (advisory, not a required check) — verdict: PASS · CI green

PASS — The latest fix restores legacy handling for malformed net_payment_term shapes instead of forwarding them for casting, with regression coverage showing customer upserts and billing-entity updates preserve existing terms.