Auto zoom when adding a layer from the UI by nakul-py · Pull Request #1286 · geojupyter/jupytergis

nakul-py · 2026-04-09T11:45:55Z

Description

Auto zoom to layer's extent when adding a layer from the UI.

Also now in collaboration only zooms for whom, who created the layer, Not for all collaborators.
Respects the user view 👍

zoom-collab.mp4

Closes Zoom to data layer when calling explore(data) #667

Checklist

PR has a descriptive title and content.
PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
PR has one of the labels: documentation, bug, enhancement, feature, maintenance
Checks are passing.
Failing lint checks can be resolved with:
- pre-commit run --all-files
- jlpm run lint
If you wish to be cited for your contribution, CITATION.cff contains an author entry for yourself

📚 Documentation preview: https://jupytergis--1286.org.readthedocs.build/en/1286/
💡 JupyterLite preview: https://jupytergis--1286.org.readthedocs.build/en/1286/lite
💡 Specta preview: https://jupytergis--1286.org.readthedocs.build/en/1286/lite/specta

github-actions · 2026-04-09T11:46:04Z

👈 Launch a Binder on branch nakul-py/jupytergis/autoZoom

martinRenou · 2026-04-09T12:15:02Z

That's really cool thanks!

This PR is fixing #667

Screencast.From.2026-04-09.14-11-26.mp4

martinRenou

I badly want to merge this PR, but I don't think we can as it is... The issue is that when collaboratively annotating a map with markers we'll have the view keep on jumping whenever someone else is adding a new annotation.

We need to think of a way to track the origin of the change, and only zoom to the layer if it was created by the current user. I guess we have no way of knowing that though... Thoughts @gjmooney @davidbrochart @trungleduc ?

martinRenou · 2026-04-09T12:45:15Z

We could introduce in our document model an "origin" attribute for Layers, that's a UUID generated by the front-end.

If the origin of the layer is the same as the current page, we do zoom.

I wonder if the added "noise" in the document would make it annoying or if it would be just fine.

gjmooney · 2026-04-09T14:18:27Z

Doesn't the awareness stuff have a unique identifier? Could we use that as the origin?Alternatively, we could disable the zoom if there's other collaborators connected?

martinRenou · 2026-04-09T14:43:17Z

Alternatively, we could disable the zoom if there's other collaborators connected?

Probably that's a good degraded solution for now indeed 👍🏽 then we don't mess around with the document model (yet?).

If we really want that in the multi-collaborators case we can rethink this later.

mfisher87 · 2026-04-09T15:03:47Z

Couldn't this be an event in the awareness, but not the document, like cursor moves? I feel like I'm missing something important here!

martinRenou · 2026-04-10T12:54:18Z

Couldn't this be an event in the awareness

Indeed I guess we could explore having a new entry in the awareness, last_created_layer?
Then we can maybe try to react on it being changed for the current user view?

If we take this approach, we need to hack around the awareness when it comes from Python.

Can you maybe test this approach @nakul-py ?

mfisher87 · 2026-04-10T17:03:09Z

If we take this approach, we need to hack around the awareness when it comes from Python.

Not sure what you mean by "hack" here, but to me the least hacky way to do this would be to specify the source of the event -- was it triggered by an LLM, by programmatic API call, or by user interaction?

e.g. lastCreatedLayer: {id: "...", source: "PythonAPI", userId: "..."}?

I know very little about this part of JupyterGIS and I'd like to learn more about it and see and touch it. Maybe we could have a session to pair/group program on it some time?

martinRenou · 2026-04-14T08:50:28Z

  syncSelected(value: { [key: string]: ISelection }, emitter?: string): void {
    this.sharedModel.awareness.setLocalStateField('selected', {
      value,
      emitter,
    });
  }

+  syncLastAddedLayer(layerId: string): void {
+    this.sharedModel.awareness.setLocalStateField('lastAddedLayer', {
+      layerId,
+      clientId: this.getClientId(),
+    });
+  }


Can you double check why we don't need to inject clientId for syncSelected but we do for "lastAddedLayer"? Since the selection is bound to the current user I assume it's bound to the clientId somehow too. So you probably don't need to add clientId here. To be confirmed.

OK let me check this one 👍

Yes we can get rid of manually adding clientId and getting it from awareness.

martinRenou · 2026-04-14T09:05:27Z

This is looking nice!

Although for the Python API it does not work how we want:

Screencast.From.2026-04-14.10-55-08.mp4

If we take this approach, we need to hack around the awareness when it comes from Python.

Not sure what you mean by "hack" here, but to me the least hacky way to do this would be to specify the source of the event

Now, that is what I meant. The Python API does not write into the awareness so we'll need to have a special case for this one.

martinRenou

Thanks! Let's get this one in and figure out the Python case separately. #1246 will probably help us, or at least be a good step in the direction we want.

Auto zoom when adding a layer from the UI

eed1613

nakul-py added the enhancement New feature or request label Apr 9, 2026

nakul-py requested a review from martinRenou April 9, 2026 11:46

martinRenou requested changes Apr 9, 2026

View reviewed changes

geojupyter-pr-triage bot added this to JupyterGIS PR triage Apr 9, 2026

nakul-py added 2 commits April 12, 2026 17:15

stop zoom if users > 0

350a39f

finally zooms on prior who created the layer

18eaf79

nakul-py requested a review from martinRenou April 13, 2026 14:38

sync lastAddedLayer with awareness

b3d79fa

martinRenou reviewed Apr 14, 2026

View reviewed changes

remove manual clientId

e18331c

martinRenou self-assigned this Apr 16, 2026

martinRenou approved these changes Apr 16, 2026

View reviewed changes

martinRenou merged commit 8152da7 into geojupyter:main Apr 16, 2026
16 checks passed

github-project-automation bot moved this to Done in JupyterGIS PR triage Apr 16, 2026

nakul-py deleted the autoZoom branch April 16, 2026 14:20

geojupyter-pr-triage bot removed this from JupyterGIS PR triage Apr 16, 2026

Conversation

nakul-py commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

martinRenou commented Apr 9, 2026

Uh oh!

martinRenou left a comment

Choose a reason for hiding this comment

Uh oh!

martinRenou commented Apr 9, 2026

Uh oh!

gjmooney commented Apr 9, 2026

Uh oh!

martinRenou commented Apr 9, 2026

Uh oh!

mfisher87 commented Apr 9, 2026

Uh oh!

martinRenou commented Apr 10, 2026

Uh oh!

mfisher87 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martinRenou Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nakul-py Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nakul-py Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

martinRenou commented Apr 14, 2026

Uh oh!

martinRenou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nakul-py commented Apr 9, 2026 •

edited

Loading

mfisher87 commented Apr 10, 2026 •

edited

Loading