Skip to content

fix(utils): reject trailing characters in numFromString #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dankmeme01 merged 3 commits into from
Aug 27, 2026
Merged

fix(utils): reject trailing characters in numFromString #2166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e434190
fix(utils): reject trailing characters in numFromString
slideglide Aug 23, 2026
cd434d4
replace unknown error with error code message
slideglide Aug 23, 2026
86ea531
small change: remove "extra" from the trailing data error
slideglide Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions loader/src/utils/general.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@ float geode::utils::getDisplayFactor() {
template <typename T>
static Result<T> toParseResult(T* value, fast_float::from_chars_result res, std::string_view str) {
auto [ptr, ec] = res;
if (ec == std::errc()) return Ok(*value);
else if (ptr != str.data() + str.size()) return Err("String contains trailing extra data");
else if (ec == std::errc::invalid_argument) return Err("String is not a number");
else if (ec == std::errc::result_out_of_range) return Err("Number is out of range for target type");
else return Err("Unknown error");

if (ec == std::errc::invalid_argument) return Err("String is not a number");
if (ec == std::errc::result_out_of_range) return Err("Number is out of range for target type");
if (ec != std::errc()) return Err(std::make_error_code(ec).message());

if (ptr != str.data() + str.size()) return Err("String contains trailing data");

return Ok(*value);
}

template <typename T>
Expand Down
Loading