Update Broma and other used packages to latest versions - #1341
Merged
Conversation
Stazzical
commented
Aug 14, 2026
Stazzical
left a comment
Stazzical
left a comment
Contributor
Author
There was a problem hiding this comment.
This one I had discussed with dank about and we both didn't really understand why it existed and apparently a similar macro existed in FMT 1.12's changelogs so we thought it wasn't exactly needed. The codegen had already functioned properly without it while testing personally.
Collaborator
|
It might've been added for Linux users trying to compile it to Windows, which, come to think of it, might not be relevant since there's native Linux builds anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates geode-sdk/Broma to the latest upstream and applies necessary changes for staying functional.
Broma now uses the geode-sdk/result package for file parsing.
Compiles and runs fine for me locally.