Skip to content

Preserve trusted reply contexts in delivery feedback - #48

Open
albert-mr wants to merge 2 commits into
genlayerlabs:mainfrom
albert-mr:fix/retain-host-reply-context
Open

albert-mr wants to merge 2 commits into
genlayerlabs:mainfrom
albert-mr:fix/retain-host-reply-context

Conversation

@albert-mr

@albert-mr albert-mr commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

When eight newer messages evict a completed turn's parent from the inbound cache, delivery feedback loses the parent ID. Hosts can then mistake a delayed answer for newer pending work. Held replies from different turns also lose their distinct parents when combined.

Preserve the original host-issued contexts in after_delivery metadata as reply_contexts, including every distinct context in a held batch. Duplicate held text is sent once while retaining all of its native contexts, and mixed-parent batches have no Telegram reply tag. Telegram reply tags still use the existing validation, and ordinary model messages cannot supply trusted contexts. Hosts can acknowledge the captured turns only after successful delivery.

Validation: mix test — 262 tests, 0 failures. Two new regressions failed before the held-duplicate fix and now pass. Previously reported Genmochi validation: five PostgreSQL integration regressions covering delayed replies, coalesced inputs, cache eviction, failed delivery, and parentless operator turns; these were not rerun for the follow-up fix.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3f480006-7e0f-4cc1-abd2-144b77769e3a

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@albert-mr
albert-mr marked this pull request as ready for review September 30, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant