Repository navigation
fix: scope fee profiles to their measured chain - #3
Merged
Merged
Conversation
Require explicit chain-id provenance before developer allocations can seed a quote. If a matched profile falls below the live execution-budget floor, discard it and re-estimate with SDK defaults so the returned distribution and fee value remain coherent. Validated with core profile-selection regressions, full workspace tests, typecheck, build, and package dry-run.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainIdprovenance before applying developer fee suggestionsRoot cause
Profile selection used only deploy/method name. The human-readable network label was not a security boundary, so allocations measured for one chain could be reused on another while live price-cap verification still passed.
Validation
Downstream
The testing-suite profile generator must emit numeric
chainId. Legacy profiles deliberately fall back to network defaults, and the Boilerplate RC no longer loads its stale profile.