Repository navigation
fix: keep adapters compatible with core package - #2
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use core's exported public types from both UI adapters instead of maintaining divergent structural copies. Declare and validate an exact core peer dependency, and normalize the SDK's public numeric input forms in adapter mocks. This prevents publishing an RC whose separately installed core and adapter types are incompatible in real consumers.
MuncleUscles
force-pushed
the
fix/rc1-adapter-core-compat
branch
from
September 3, 2026 13:48
7aee9e2 to
7d8c625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
The packed React and Vue adapters maintained hand-copied structural versions of the core API. The published declarations had already drifted: a real
@genlayer/transaction-kitinstance could not be passed to the adapter components because theirtopUpinput types disagreed. This would make0.1.0-rc.1unusable in TypeScript consumers such as the v2 Boilerplate.Use the core package as the single source of truth for adapter public types. Keep the relationship type-only at runtime, and declare the exact matching core package as a peer.
Implementation and validation
Validation:
npm run typechecknpm run buildnpm test(46 package tests + 6 release-policy tests)npm run pack:checkNo runtime imports were added to the adapters. Rollback is the single commit on this branch.