Skip to content

test: make wallet session descriptor tests portable - #373

Merged
MuncleUscles merged 1 commit into
v0.40-devfrom
codex/clarke-rc2
Jul 9, 2026
Merged

MuncleUscles merged 1 commit into
v0.40-devfrom
codex/clarke-rc2

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Fixes the Windows-only CI failure in wallet session descriptor tests before cutting the next Clarke prerelease.\n\nChanges:\n- compare descriptor paths using platform-native path.join\n- skip Unix 0600 mode assertion on Windows, where chmod semantics do not match POSIX\n\nLocal verification:\n- npm test -- tests/libs/sessionDescriptor.test.ts\n- npm run build

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8310f3e9-2e17-4e82-9564-b0b7553a9012

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/clarke-rc2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MuncleUscles
MuncleUscles merged commit f892371 into v0.40-dev Jul 9, 2026
9 of 10 checks passed
@MuncleUscles
MuncleUscles deleted the codex/clarke-rc2 branch July 9, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant