[Bug] _from_v06 hardcodes tx_execution_result=0, hiding actual execution results on Bradbury #308
Description
Description
In genlayer_py/types/transactions.py:437, the _from_v06 class method hardcodes tx_execution_result=0 instead of reading it from the transaction data.
Impact
- Any code using
from_transaction_data()will always showNOT_VOTEDas execution result on Bradbury and Asimov testnets. - Users cannot distinguish between successful and failed contract executions via this field.
- While
get_transaction()overrides this viagetTransactionAllData, thefrom_transaction_data()path remains broken.
Suggested Fix
Map tx_execution_result from the appropriate field in the decoded tuple. For V06, tx_data[9] is txExecutionHash and may contain the execution result.
Notes
tx_execution_resultmaps to:0 = NOT_VOTED,1 = SUCCESS,2 = FAILURE- Affects all users of Bradbury/Asimov testnets using
from_transaction_data()
Activity
2TheMoom commentedon Sep 3, 2026
The code this references actually lives in
genlayerlabs/genlayer-py(genlayer_py/types/transactions.py), not this repo — this repo doesn't have agenlayer_py/package. Confirmed the bug is still live there onv0.18.One correction on the suggested fix:
tx_data[9]in the v06 shape istxExecutionHash, abytes32hash — not a result code — per the existing comment two lines above it in_from_v06. There's no field in the lightgetTransactionABI to remap; it structurally doesn't carry an execution result on either the v04 or v06 shape (onlygetTransactionAllDatadoes).Opened genlayerlabs/genlayer-py#114 against
v0.18: widenstx_execution_resulttoOptional[int]and returnsNonefrom the light decode instead of the misleading0(which aliases to the realNOT_VOTEDstatus), with a regression test covering both ABI shapes plus the unaffectedgetTransactionAllDatapath.