Skip to content

feat: send emdash version with feedback#1730

Merged
rabanspiegel merged 1 commit intogeneralaction:mainfrom
jschwxrz:feat-add-emdash-version-feedback-gqi6w
Apr 16, 2026
Merged

feat: send emdash version with feedback#1730
rabanspiegel merged 1 commit intogeneralaction:mainfrom
jschwxrz:feat-add-emdash-version-feedback-gqi6w

Conversation

@jschwxrz
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 16, 2026

Greptile Summary

This PR enriches the feedback payload sent to the Discord webhook by appending the running app version (sourced from AppContextProvider) to the metadata block. The implementation is correct: optional chaining handles the loading state, the 'unknown' fallback covers the case where the query hasn't resolved, and appVersion is properly added to the useCallback dependency array.

Confidence Score: 5/5

Safe to merge — the change is minimal, correct, and well-guarded against edge cases.

All changes are P2 or lower. The version is read from an existing context query, the undefined case is handled with a fallback, and the dependency array is updated correctly. No logic errors or regressions were found.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/components/FeedbackModal.tsx Adds appVersion from AppContextProvider to feedback metadata; appends it to the Discord webhook payload with a safe 'unknown' fallback and correctly adds it to the useCallback dependency array.

Sequence Diagram

sequenceDiagram
    participant User
    participant FeedbackModal
    participant AppContextProvider
    participant ElectronAPI
    participant DiscordWebhook

    AppContextProvider->>ElectronAPI: getAppVersion()
    ElectronAPI-->>AppContextProvider: version string (or undefined)
    User->>FeedbackModal: opens modal
    FeedbackModal->>AppContextProvider: useAppContext() → appVersion
    User->>FeedbackModal: submits feedback
    FeedbackModal->>FeedbackModal: build metadataLines (Contact, GitHub, Emdash Version)
    FeedbackModal->>DiscordWebhook: POST content with metadata
    DiscordWebhook-->>FeedbackModal: 200 OK
    FeedbackModal-->>User: toast("Feedback sent")
Loading

Reviews (1): Last reviewed commit: "feat: send emdash version with feedback" | Re-trigger Greptile

@rabanspiegel rabanspiegel merged commit 371e553 into generalaction:main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants