Save addressNames from API during transaction sync (Android) by DRadmir · Pull Request #214 · gemwalletcom/wallet

DRadmir · 2026-04-23T18:00:03Z

Mirrors iOS address-name handling on Android: persists names from the API,
surfaces them in the transaction list and details, and keeps them in sync
when a wallet is renamed.

Schema:

Add addresses table (PK chain+address; columns chain/address/wallet_id/
name/type/status). The optional wallet_id lets us mark the user's own
accounts as InternalWallet/Verified and rename them along with their
wallet
Bump DB version 72 -> 73 (Migration_72_73) — creates the table and seeds
existing accounts as internal addresses

Domain:

Add SaveAddressNames, GetAddressName, RenameWalletAddresses cases
backed by a thin AddressesRepository
Register DAO, migration, and Hilt bindings

Sync:

Add addressNames to TransactionsResponse (defaults to empty for
back-compat)
SyncTransactionsImpl calls saveAddressNames after saving transactions,
matching iOS call order
WalletsRepositoryImpl.putWallet seeds the user's own accounts into
addresses
Renaming a wallet propagates the new name to its address-book entries

Closes #10

Mirror iOS TransactionsService which calls addressStore.addAddressNames after syncing transactions. Android was dropping response.addressNames on the floor. Schema: - Add addresses table (PK chain+address, columns chain/address/name/ type/status) matching iOS AddressRecord; no wallet_id — entries are external (validators, contacts) - Bump DB version 70 -> 71 with Migration_70_71 Domain: - Add SaveAddressNames case in gemcore - Add thin AddressesRepository wrapping AddressesDao - Register DAO, migration, and Hilt bindings Wiring: - Add addressNames to TransactionsResponse (defaults to emptyList for back-compat) - Inject SaveAddressNames into SyncTransactionsImpl and call after saveTransactions, mirroring iOS call order Closes #10

…dressnames-from-api-during-transaction-sync

- Rename counterpartyAddress to participantAddressName for consistency with participantAddress - Inline Account.toAddressRecord into Wallet.toAddressRecords (single-use helper) - Remove outdated SyncTransactionsImplTest

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/repositories/src/main/kotlin/com/gemwallet/android/data/repositories/di/WalletsModule.kt # android/data/repositories/src/main/kotlin/com/gemwallet/android/data/repositories/wallets/WalletsRepositoryImpl.kt # android/data/services/store/schemas/com.gemwallet.android.data.service.store.database.GemDatabase/71.json # android/data/services/store/src/main/kotlin/com/gemwallet/android/data/service/store/database/GemDatabase.kt # android/data/services/store/src/main/kotlin/com/gemwallet/android/data/service/store/database/di/DatabaseModule.kt # android/data/services/store/src/main/kotlin/com/gemwallet/android/data/service/store/database/di/Migration_70_71.kt # android/data/services/store/src/main/kotlin/com/gemwallet/android/data/service/store/database/entities/DbTransactionExtended.kt

gemcoder21 · 2026-05-04T18:11:07Z

+        db.execSQL(
+            """
+                CREATE TABLE IF NOT EXISTS `addresses` (
+                    `chain` TEXT NOT NULL,


add fk link to assets

gemcoder21 · 2026-05-04T18:11:15Z

+                    `status` TEXT NOT NULL,
+                    PRIMARY KEY(`chain`, `address`),
+                    FOREIGN KEY(`wallet_id`) REFERENCES `wallets`(`id`)
+                        ON UPDATE CASCADE ON DELETE CASCADE


one liner, remove trimIndent

gemcoder21 · 2026-05-04T18:12:37Z

    LEFT JOIN tx_swap_metadata as swap ON tx.id = swap.tx_id
    LEFT JOIN asset as from_asset ON swap.from_asset_id = from_asset.id
    LEFT JOIN asset as to_asset ON swap.to_asset_id = to_asset.id
+    LEFT JOIN addresses as from_addr ON from_addr.chain = asset.chain AND from_addr.address = tx.owner


Suggested change

LEFT JOIN addresses as from_addr ON from_addr.chain = asset.chain AND from_addr.address = tx.owner

LEFT JOIN addresses as from_addr ON from_addr.chain = asset.chain AND from_addr.address = transaction.owner

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/GetTransactionsImpl.kt

Mirrors the iOS AddressRecord FK and aligns with how master's Migration_71_72 wires accounts.chain to asset(id). Adds an index on chain so the FK doesn't trigger full-table scans.

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/SyncTransactionsImpl.kt # android/data/services/store/src/main/kotlin/com/gemwallet/android/data/service/store/database/TransactionsDao.kt # android/gemcore/src/main/kotlin/com/gemwallet/android/model/Transaction.kt

- Drop seeding from Migration_72_73; addresses populate via SaveAddressNames sync and putWallet - Rename DbAddressNameProjection to DbAddressProjection to match DbAssetProjection naming - Drop redundant open/override val on Destination sealed subclasses

gemcoder21 · 2026-05-07T18:27:27Z

+                    `status` TEXT NOT NULL,
+                    PRIMARY KEY(`chain`, `address`),
+                    FOREIGN KEY(`chain`) REFERENCES `asset`(`id`) ON UPDATE CASCADE ON DELETE CASCADE,
+                    FOREIGN KEY(`wallet_id`) REFERENCES `wallets`(`id`) ON UPDATE CASCADE ON DELETE CASCADE


Suggested change

FOREIGN KEY(`wallet_id`) REFERENCES `wallets`(`id`) ON UPDATE CASCADE ON DELETE CASCADE

FOREIGN KEY(`walletId`) REFERENCES `wallets`(`id`) ON UPDATE CASCADE ON DELETE CASCADE

gemcoder21 · 2026-05-07T18:27:40Z

+data class DbAddress(
+    val chain: Chain,
+    val address: String,
+    @ColumnInfo(name = "wallet_id") val walletId: String?,


Suggested change

@ColumnInfo(name = "wallet_id") val walletId: String?,

val walletId: String?,

gemcoder21 · 2026-05-07T18:28:56Z

+    val address: String,
+    @ColumnInfo(name = "wallet_id") val walletId: String?,
+    val name: String,
+    val type: AddressType?,


Suggested change

val type: AddressType?,

val type: AddressType,

gemcoder21 · 2026-05-07T18:29:45Z

+)
+
+data class DbAddressProjection(
+    val chain: Chain?,


should not be optional?

gemcoder21 · 2026-05-07T18:30:59Z

+package com.gemwallet.android.cases.addresses
+
+interface RenameWalletAddresses {
+    suspend fun renameWalletAddresses(walletId: String, name: String)


Suggested change

suspend fun renameWalletAddresses(walletId: String, name: String)

suspend fun rename(walletId: WalletId, name: String)

gemcoder21 · 2026-05-07T18:31:42Z

    val address: String
+    val addressName: String?
+        get() = null
+    val addressType: AddressType?


address: (name, type) ? maybe new struct?

gemcoder21 · 2026-05-07T18:33:23Z

+                    `address` TEXT NOT NULL,
+                    `wallet_id` TEXT,
+                    `name` TEXT NOT NULL,
+                    `type` TEXT,


Suggested change

`type` TEXT,

`type` TEXT NOT NULL,

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/SyncTransactionsImpl.kt

- Bump core: AddressName.address_type is now AddressType (non-optional) - Regenerate AddressName bindings on Android and iOS - Android: DbAddress.type, DbAddressProjection.type, addresses.type column become non-null; bump 73.json schema - iOS: AddressRecord.type non-null with .notNull schema; add Backfill type migration so legacy NULL rows decode - Drop unused TransactionDataAggregate.addressType (no consumer reads it) - Rename RenameWalletAddresses.renameWalletAddresses(walletId: String, ...) to rename(walletId: WalletId, ...) per review

DRadmir self-assigned this Apr 23, 2026

DRadmir added the Android label Apr 23, 2026

DRadmir added 2 commits April 24, 2026 10:44

Merge branch 'main' of github.com:gemwalletcom/wallet into 10-save-ad…

6d960fb

…dressnames-from-api-during-transaction-sync

Tidy address name helpers on Android

749c374

- Rename counterpartyAddress to participantAddressName for consistency with participantAddress - Inline Account.toAddressRecord into Wallet.toAddressRecords (single-use helper) - Remove outdated SyncTransactionsImplTest

DRadmir force-pushed the 10-save-addressnames-from-api-during-transaction-sync branch from 6f45a9f to 749c374 Compare April 24, 2026 09:24

DRadmir marked this pull request as ready for review April 24, 2026 09:27

DRadmir marked this pull request as draft April 28, 2026 09:15

DRadmir force-pushed the 10-save-addressnames-from-api-during-transaction-sync branch from e9673ae to b3dca91 Compare April 29, 2026 17:22

DRadmir force-pushed the 10-save-addressnames-from-api-during-transaction-sync branch from b3dca91 to e3bcb70 Compare April 29, 2026 17:38

DRadmir marked this pull request as ready for review April 29, 2026 18:04

DRadmir requested a review from gemcoder21 April 29, 2026 18:04

gemcoder21 approved these changes May 4, 2026

View reviewed changes

DRadmir added 4 commits May 5, 2026 12:14

Merge branch 'main' of github.com:gemwalletcom/wallet into 10-save-ad…

cd62bef

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/GetTransactionsImpl.kt

Add FK from addresses.chain to asset(id)

79b1d01

Mirrors the iOS AddressRecord FK and aligns with how master's Migration_71_72 wires accounts.chain to asset(id). Adds an index on chain so the FK doesn't trigger full-table scans.

Clean up address-name plumbing

0e89631

- Drop seeding from Migration_72_73; addresses populate via SaveAddressNames sync and putWallet - Rename DbAddressNameProjection to DbAddressProjection to match DbAssetProjection naming - Drop redundant open/override val on Destination sealed subclasses

gemcoder21 reviewed May 7, 2026

View reviewed changes

gemcoder21 approved these changes May 7, 2026

View reviewed changes

DRadmir added 2 commits May 8, 2026 11:01

Merge branch 'main' of github.com:gemwalletcom/wallet into 10-save-ad…

3531f99

…dressnames-from-api-during-transaction-sync # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/SyncTransactionsImpl.kt

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save addressNames from API during transaction sync (Android)#214

Save addressNames from API during transaction sync (Android)#214
DRadmir wants to merge 10 commits intomainfrom
10-save-addressnames-from-api-during-transaction-sync

DRadmir commented Apr 23, 2026 •

edited

Loading

Uh oh!

gemcoder21 May 4, 2026

Uh oh!

gemcoder21 May 4, 2026

Uh oh!

gemcoder21 May 4, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

gemcoder21 May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	LEFT JOIN addresses as from_addr ON from_addr.chain = asset.chain AND from_addr.address = tx.owner
	LEFT JOIN addresses as from_addr ON from_addr.chain = asset.chain AND from_addr.address = transaction.owner

	FOREIGN KEY(`wallet_id`) REFERENCES `wallets`(`id`) ON UPDATE CASCADE ON DELETE CASCADE
	FOREIGN KEY(`walletId`) REFERENCES `wallets`(`id`) ON UPDATE CASCADE ON DELETE CASCADE

	@ColumnInfo(name = "wallet_id") val walletId: String?,
	val walletId: String?,

	suspend fun renameWalletAddresses(walletId: String, name: String)
	suspend fun rename(walletId: WalletId, name: String)

Conversation

DRadmir commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DRadmir commented Apr 23, 2026 •

edited

Loading