Skip to content

Impl send/stake messages for Cosmos Signer#1107

Open
0xh3rman wants to merge 3 commits intomainfrom
cosmos-signer
Open

Impl send/stake messages for Cosmos Signer#1107
0xh3rman wants to merge 3 commits intomainfrom
cosmos-signer

Conversation

@0xh3rman
Copy link
Copy Markdown
Collaborator

@0xh3rman 0xh3rman commented May 6, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for staking operations—including delegation, undelegation, redelegation, and reward withdrawal—within the Cosmos signer. It refactors message handling to accommodate chain-specific requirements for Thorchain and Injective, adds the k256 dependency for public key uncompression, and includes unit tests for Injective transfers. Review feedback suggests reducing code duplication between transfer signing methods and simplifying several exhaustive match statements using wildcards to improve maintainability.

Comment thread crates/gem_cosmos/src/signer/chain_signer.rs
Comment thread crates/gem_cosmos/src/signer/chain_signer.rs
Comment thread crates/gem_cosmos/src/signer/chain_signer.rs
Comment thread crates/gem_cosmos/src/signer/transaction.rs
Comment thread crates/gem_cosmos/src/signer/transaction.rs
@0xh3rman 0xh3rman changed the title impl cosmos signer Impl send/stake messages for Cosmos Signer May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant