fix(ethexe-network): Partial hashes response in db-sync

[ark0f]

Fix for #5146

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/network/src/db_sync/requests.rs	39% smaller
ethexe/network/src/utils.rs	25% smaller
ethexe/network/src/db_sync/responses.rs	12% smaller
ethexe/network/src/db_sync/mod.rs	10% smaller

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues related to network response sizes by introducing truncation logic for hash-based requests. It also simplifies the request handling architecture by removing round-based limits in favor of a more streamlined approach, improving the robustness of the db-sync network communication.

Highlights

• Response Truncation: Implemented logic to truncate Hashes responses to ensure they do not exceed the maximum allowed encoded size, preventing potential network errors.
• Request Logic Refactoring: Removed the max_rounds_per_request configuration and associated logic, simplifying the request retry mechanism to rely on timeouts instead.
• Test Suite Updates: Updated existing tests to reflect the removal of round-based logic and added a new test case to verify correct truncation of large hash responses.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7afbc2076d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[gemini-code-assist]

Code Review

This pull request refactors the db_sync request logic by removing the max_rounds_per_request configuration and associated state tracking, simplifying the request loop to rely on peer availability and timeouts. It also introduces a size-limited truncation mechanism for Hashes responses to ensure they remain within the ParityScaleCodec limits. I have provided feedback regarding a potential compilation error in the request loop and an optimization for the response size calculation.