Don't install vendored backward files (take II)#3088
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
azeey
left a comment
azeey
left a comment
There was a problem hiding this comment.
I guess I'm not sure why we need to even include the CMakeListst.txt of our vendored backward-cpp. Since it's a header-only library, I would think we can just include the header without installing it.
| ) | ||
| # check if Backward is being used as a top-level project or included as a subproject | ||
| if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR) | ||
| install( |
There was a problem hiding this comment.
If I undesrtand this correctly, this would still install the header since it's being included as a subproject in our top level CMakeLists.txt file
There was a problem hiding this comment.
CMAKE_SOURCE_DIR should equal to the root of the gz-sim repository while PROJECT_SOURCE_DIR should be equal to the vendor/backwards-cpp subdirectory on top of the root of the gz-sim repository. So we are using it but the file is not a top-level project.
There was a problem hiding this comment.
While the logic make sense, why not completely remove it since we are patching this already?
There was a problem hiding this comment.
@j-rivero, I agree. It would be simpler to remove the install calls.
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
|
Looks like the pre-commit test failed. Let's try to get this merged before making the stable release. |
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
attempting a fix in 62d8dfc |
fix later Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I just removed the whitespace from the patch and reverted my other changes. This makes the patch invalid, so I filed #3096 to record the issue |
* Back to skip the backwards-cpp vendor files when installing Signed-off-by: Steve Peters <scpeters@openrobotics.org> --------- Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
* Back to skip the backwards-cpp vendor files when installing Signed-off-by: Steve Peters <scpeters@openrobotics.org> --------- Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
5 participants
🦟 Bug fix
Retake of #2838
Summary
See #2919 (review).
The PR adds a file for visibility if the version is updated at some point.
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.