Skip to content

fix: early return in toolbar button to avoid unneeded calls to useInt… #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 3 commits into from
May 29, 2026
+5 −2
Merged

fix: early return in toolbar button to avoid unneeded calls to useInt… #24

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd7e8e
fix: early return in toolbar button to avoid unneeded calls to useInt…
Arukuen May 5, 2026
8ca2974
fix: isolate interactionsFiltered into separate useSelect to reduce e…
Arukuen May 5, 2026
851b6bc
fix: use specific dependency to avoid extra calls
Arukuen May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/editor/hooks/use-interactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,19 +244,22 @@ const useInteractions = () => {
}

const interactions = select( 'interact/interactions' ).getInteractions()
const interactionsFiltered = interactions.filter( interaction => isInteractionShown( interaction, select ) )

return {
interactions,
interactionsFiltered,
setInteractions,
updateInteraction,
deleteInteraction,
}
}, [] )

const interactionsFiltered = useSelect( select => {
return data.interactions.filter( interaction => isInteractionShown( interaction, select ) )
}, [ data ] )
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

return {
loadingError: useSelect( select => select( 'interact/interactions' ).getLoadingError(), [] ),
interactionsFiltered,
...data,
}
}
Expand Down
Loading