Skip to content

Fall back to sqlite when database creation fails #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsoranzo merged 3 commits into from
Oct 15, 2025
Merged

Fall back to sqlite when database creation fails #1576

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be43f1d
Fall back to sqlite when database creation fails
mvdbeek Oct 15, 2025
ad2557a
Fall back to sqlite only if database type is set to auto
mvdbeek Oct 15, 2025
f2f947c
handle sqlite explicitly
mvdbeek Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions planemo/galaxy/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def _create_profile_docker(ctx, profile_directory, profile_name, kwds):

def _create_profile_local(ctx, profile_directory, profile_name, kwds):
database_type = kwds.get("database_type", "auto")
allow_sqlite_fallback = database_type == "auto"
if database_type == "auto":
if which("psql"):
database_type = "postgres"
Expand All @@ -97,10 +98,21 @@ def _create_profile_local(ctx, profile_directory, profile_name, kwds):
if database_type not in ["sqlite", "postgres_singularity"]:
database_source = create_database_source(**kwds)
database_identifier = _profile_to_database_identifier(profile_name)
database_source.create_database(
database_identifier,
)
database_connection = database_source.sqlalchemy_url(database_identifier)
try:
database_source.create_database(
database_identifier,
)
except RuntimeError:
if allow_sqlite_fallback:
# If postgres database creation fails (e.g., role doesn't exist, connection issues),
# fall back to sqlite
database_type = "sqlite"
database_location = os.path.join(profile_directory, "galaxy.sqlite")
database_connection = DATABASE_LOCATION_TEMPLATE % database_location
Comment thread
mvdbeek marked this conversation as resolved.
Outdated
else:
raise
else:
database_connection = database_source.sqlalchemy_url(database_identifier)
elif database_type == "postgres_singularity":
database_connection + database_source.sqlalchemy_url(database_identifier)
Comment thread
nsoranzo marked this conversation as resolved.
else:
Comment thread
mvdbeek marked this conversation as resolved.
Outdated
Expand Down