Skip to content

Update fasttree 2.1.10+galaxy1 to 2.1.10+galaxy3 in PathoGFAIR workflow.#1162

Open
jmchilton wants to merge 1 commit intogalaxyproject:mainfrom
jmchilton:update-fasttree-version
Open

Update fasttree 2.1.10+galaxy1 to 2.1.10+galaxy3 in PathoGFAIR workflow.#1162
jmchilton wants to merge 1 commit intogalaxyproject:mainfrom
jmchilton:update-fasttree-version

Conversation

@jmchilton
Copy link
Copy Markdown
Member

Both intermediate releases are Galaxy-level bug fixes with no input/output changes:

The toolshed doesn't have the version listed in the workflow anymore - looking over galaxyproject/tools-iuc#6640 I can imagine why. My first thought was maybe we broke the tool loading in galaxyproject/galaxy#15493. But that behavior was trying to block on a tool version. The problem isn't immediately clear but I could put more time into if want to push back and call this a tool shed bug - I could try to re-implement boolean parameters that have matching truevalues and falsevalues if they are empty.

FOR CONTRIBUTOR:

  • I have read the Adding workflows guidelines
  • License permits unrestricted use (educational + commercial)
  • Please also take note of the reviewer guidelines below to facilitate a smooth review process.

FOR REVIEWERS:

  • .dockstore.yml: file is present and aligned with creator metadata in workflow. ORCID identifiers are strongly encouraged in creator metadata. The .dockstore.yml file is required to run tests
  • Workflow is sufficiently generic to be used with lab data and does not hardcode sample names, reference data and can be run without reading an accompanying tutorial.
  • In workflow: annotation field contains short description of what the workflow does. Should start with This workflow does/runs/performs … xyz … to generate/analyze/etc …
  • In workflow: workflow inputs and outputs have human readable names (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless it is generally understood. Altering input or output labels requires adjusting these labels in the the workflow-tests.yml file as well
  • In workflow: name field should be human readable (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless generally understood
  • Workflow folder: prefer dash (-) over underscore (_), prefer all lowercase. Folder becomes repository in iwc-workflows organization and is included in TRS id
  • Readme explains what workflow does, what are valid inputs and what outputs users can expect. If a tutorial or other resources exist they can be linked. If a similar workflow exists in IWC readme should explain differences with existing workflow and when one might prefer one workflow over another
  • Changelog contains appropriate entries
  • Large files (> 100 KB) are uploaded to zenodo and location urls are used in test file

@jmchilton
Copy link
Copy Markdown
Member Author

I guess the bot has an update that would have caught this with https://github.com/galaxyproject/iwc/pull/758/changes - but that change is a lot more expansive.

Both intermediate releases are Galaxy-level bug fixes with no input/output
changes:
- galaxy1→galaxy2: fix version_command (galaxyproject/tools-iuc#3114)
- galaxy2→galaxy3: fix tool XML declaration (galaxyproject/tools-iuc#6640)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant