Skip to content

Revise text-based markdown editor, remove associated side panel#19885

Closed
guerler wants to merge 32 commits intogalaxyproject:devfrom
guerler:revise_text_based_markdown_editor
Closed

Revise text-based markdown editor, remove associated side panel#19885
guerler wants to merge 32 commits intogalaxyproject:devfrom
guerler:revise_text_based_markdown_editor

Conversation

@guerler
Copy link
Copy Markdown
Contributor

@guerler guerler commented Mar 24, 2025

Requires #19775. This PR sets the cell-based Markdown editor as the default and removes the previously required Markdown side panel.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

guerler added 30 commits March 21, 2025 10:13
@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Mar 24, 2025
@guerler guerler added this to the 25.0 milestone Mar 24, 2025
@jmchilton
Copy link
Copy Markdown
Member

I think the document-based editor should remain the default paradigm and should be invested in. I think the goal should organic documents and not ad-hoc Jupyter-lite. I really didn't understand this was the goal when you added the cell editor.

@guerler
Copy link
Copy Markdown
Contributor Author

guerler commented Mar 24, 2025

Ok, closing this for now, and leaving the text-based editor as is with it's panel.

@guerler guerler closed this Mar 24, 2025
@guerler
Copy link
Copy Markdown
Contributor Author

guerler commented Mar 24, 2025

@jmchilton yes the goal was to find a better solution for the side panel with markdown items which are inserted at the last cursor position, another goal was to introduce previews. I am totally ok, with leaving the document-based editor as default even if we remove the side panel at one point.

@itisAliRH itisAliRH deleted the revise_text_based_markdown_editor branch March 31, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants