Improve markdown editor modularity and structure#19835
Merged
guerler merged 39 commits intogalaxyproject:devfrom Mar 19, 2025
Merged
Improve markdown editor modularity and structure#19835guerler merged 39 commits intogalaxyproject:devfrom
guerler merged 39 commits intogalaxyproject:devfrom
Conversation
…yles, use section wrapper
…om reports to pages
4 tasks
davelopez
approved these changes
Mar 19, 2025
Contributor
davelopez
left a comment
There was a problem hiding this comment.
The refactoring looks good to me. Some very minor comments below.
|
|
||
| export interface WorkflowLabel { | ||
| label: string; | ||
| type: "input" | "output" | "step"; |
Contributor
There was a problem hiding this comment.
I've seen this type re-defined in several places (WorkflowLabelKind), it would be nice to have a single type definition in a common place as a single source of truth.
Contributor
Author
There was a problem hiding this comment.
Thank you, I will consolidate these in a follow-up.
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Contributor
Author
|
@davelopez thank you so much for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #19775. This PR contains various improvements to the markdown editor:
Before:

After:

How to test the changes?
(Select all options that apply)
License