Skip to content

Extend linting to expression tools#19710

Closed
bernt-matthias wants to merge 6 commits intogalaxyproject:devfrom
bernt-matthias:extend_expression_tools
Closed

Extend linting to expression tools#19710
bernt-matthias wants to merge 6 commits intogalaxyproject:devfrom
bernt-matthias:extend_expression_tools

Conversation

@bernt-matthias
Copy link
Copy Markdown
Contributor

Extends #12724 by b35c3b7

For discussion:

  • This includes expression tools in the linting. At the moment only the linters in the general module are used.
  • Also extends the check for used inputs to expressions. Not sure if its worth the extra import. One might also use it for checking/linting the expression code?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Feb 26, 2025

There are better ways to do this (included in #19434), and even more so for expression tools, unused inputs might be there for a reason.

@bernt-matthias bernt-matthias changed the title Extend linting to expression Extend linting to expression tools Feb 26, 2025
@github-actions github-actions bot added this to the 25.0 milestone Feb 26, 2025
@bernt-matthias
Copy link
Copy Markdown
Contributor Author

unused inputs might be there for a reason

Can you give me an example?

There are better ways to do this (included in #19434),

Can you point me where?

@mvdbeek
Copy link
Copy Markdown
Member

mvdbeek commented Mar 4, 2025

To wait for a dependency is one thing, there are probably other reasons too.

Can you point me where?

It's in the screenshot. Basically we build a defined interface and compile it. You can run prettier on it if you want to point out unused variables .... but see above.

@ahmedhamidawan ahmedhamidawan removed this from the 25.0 milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants