Extend linting to expression tools#19710
Closed
bernt-matthias wants to merge 6 commits intogalaxyproject:devfrom
Closed
Extend linting to expression tools#19710bernt-matthias wants to merge 6 commits intogalaxyproject:devfrom
bernt-matthias wants to merge 6 commits intogalaxyproject:devfrom
Conversation
to exclude it from application to expression tools
Member
|
There are better ways to do this (included in #19434), and even more so for expression tools, unused inputs might be there for a reason. |
Contributor
Author
Can you give me an example?
Can you point me where? |
Member
|
To wait for a dependency is one thing, there are probably other reasons too.
It's in the screenshot. Basically we build a defined interface and compile it. You can run prettier on it if you want to point out unused variables .... but see above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #12724 by b35c3b7
For discussion:
generalmodule are used.How to test the changes?
(Select all options that apply)
License