Assert that data_column parameters have a valid data_ref#18949
Merged
mvdbeek merged 3 commits intogalaxyproject:devfrom Nov 15, 2024
Merged
Assert that data_column parameters have a valid data_ref#18949mvdbeek merged 3 commits intogalaxyproject:devfrom
data_column parameters have a valid data_ref#18949mvdbeek merged 3 commits intogalaxyproject:devfrom
Conversation
d040bfb to
1e59b3b
Compare
1e59b3b to
d9938e9
Compare
6c1c978 to
5cf3bf4
Compare
Member
|
I'm unsure if this needs a profile version - I feel like we should merge it and then add the profile version if someone complains about a tool no longer loading? |
jmchilton
approved these changes
Nov 12, 2024
Contributor
Author
Usually this mean yes :) |
9b48e9a to
9877587
Compare
- it needs to be specified in the XML - needs to refer to an existing parameter
9877587 to
78a8f91
Compare
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data_refneeds to be specified in the XMLdata_refneeds to refer to an existing parameterFixes #18359 (i.e. the misleading error message, since now the
KeyErrorcaused by missing/wrongdata_refare replaced byAssertionErrorswhich will be reported properly, but still as tool loading error)Questions:
<param>?How to test the changes?
(Select all options that apply)
License