Skip to content

[21.09] JobWrapper: use correct fail method#14530

Merged
mvdbeek merged 1 commit intogalaxyproject:release_21.09from
bernt-matthias:correct-fail
Oct 17, 2022
Merged

[21.09] JobWrapper: use correct fail method#14530
mvdbeek merged 1 commit intogalaxyproject:release_21.09from
bernt-matthias:correct-fail

Conversation

@bernt-matthias
Copy link
Copy Markdown
Contributor

Extracted from #14235 .. tests will be finished there.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@bernt-matthias bernt-matthias changed the base branch from dev to release_21.09 August 29, 2022 14:25
@github-actions github-actions Bot modified the milestones: 22.09, 22.01 Aug 29, 2022
@bernt-matthias bernt-matthias changed the title JobWrapper: use correct fail method [21.09] JobWrapper: use correct fail method Sep 14, 2022
if the JobWrapper.fail method is called directly exit code (etc)
are lost.

fixes galaxyproject#14206

not sure why this error popped up now, probably a change in
tool verification ..?
@mvdbeek mvdbeek merged commit cf036f1 into galaxyproject:release_21.09 Oct 17, 2022
@github-actions
Copy link
Copy Markdown

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the correct-fail branch November 7, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants