Add a full text complaint search field - #886
Draft
dougwaldron wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
PR Overview
This PR introduces a full text complaint search field and updates related components to support broader text queries.
- Replaces the old ContainsText filter with a new ContainsDetails method and adds a ContainsAnyText filter across multiple text fields.
- Adds a new property (Text) to the search DTO and updates the UI to include a text search input.
- Updates the changelog to document the fixes and improvements in complaint search functionality.
Reviewed Changes
| File | Description |
|---|---|
| src/AppServices/Complaints/ComplaintFilters.cs | Updated filter methods to use expression-based text search and replaced the ContainsText method with ContainsDetails and ContainsAnyText. |
| CHANGELOG.md | Updated entries to reflect search fixes and UI improvements. |
| src/AppServices/Complaints/QueryDto/ComplaintSearchDto.cs | Added a new Text property for full text search and updated display names accordingly. |
| src/WebApp/Pages/Staff/Complaints/Index.cshtml | Added a new input field for text search and updated header levels for better UI structure. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/AppServices/Complaints/ComplaintFilters.cs:233
- [nitpick] Consider adding explicit parentheses in the aggregate OR expression chain to ensure the intended operator precedence and improve code clarity.
input.Split(' ', StringSplitOptions.RemoveEmptyEntries).Aggregate(predicate, (current, term) =>
src/WebApp/Pages/Staff/Complaints/Index.cshtml:176
- [nitpick] Review the change in header level from
to
for 'Source Contact' to ensure it maintains the intended semantic hierarchy and accessibility.
<h3 class="h5">Source Contact</h3>
src/AppServices/Complaints/QueryDto/ComplaintSearchDto.cs:149
- Verify that the 'Contact' property is defined in this record or inherited from IBasicSearchDisplay to avoid potential compilation issues.
Contact = Contact?.Trim(),
dougwaldron
force-pushed
the
884-simplified-search-form
branch
from
March 21, 2025 13:03
0b107f8 to
0161ed7
Compare
|
Member
Author
|
This is not ready for production as is. Some issues that need to be resolved:
|
dougwaldron
marked this pull request as draft
March 31, 2025 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.