Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions schema/va-spec/base/va-core-source.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,39 @@ $defs:
- objectTherapeutic
- conditionQualifier

GeneDiseaseValidityProposition:
inherits: va-core:Proposition
maturity: draft
type: object
description: "A proposition that variants affecting a particular Gene are valid for evaluation as causal for some Condition using appropriate variant classification criteria, given a specific mode of inheritance."
properties:
type:
extends: type
const: GeneValidityProposition
default: GeneValidityProposition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a fairly consistent convention to add a description parameter like so

        description: MUST be "GeneValidityProposition".

it feels kind of redundant to me but it's employed elsewhere in the schema

subjectGene:
extends: subject
oneOf:
- $refCurie: gks.core:MappableConcept
- $refCurie: gks.core:iriReference
predicate:
extends: predicate
const: "variantsInGeneCausalFor"
default: "variantsInGeneCausalFor"
objectCondition:
extends: object
oneOf:
- $refCurie: gks.core:MappableConcept
Comment thread
larrybabb marked this conversation as resolved.
- $refCurie: gks.core:iriReference
Comment thread
larrybabb marked this conversation as resolved.
modeOfInheritanceQualifier:
oneOf:
- $refCurie: gks.core:MappableConcept
- $refCurie: gks.core:iriReference
required:
- predicate
- subjectGene
- objectCondition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnavatar just double checking because I believe the GenCC requires MOI on their GDV classifications. Does the GCI or the ClinGen GDV SOP require MOI to be declared on every classification? The fallback is that some folks do put in the moi term "unknown" which I agree is a cop out. Just wondering if you considered this.


CohortAlleleFrequencyStudyResult:
inherits: StudyResult
maturity: trial use
Expand Down
Loading