Conversation
Further analysis shows this filter does not carry the benefit originally intended: it costs 4 dB at 3.4 kHz on top of the transmit filter and returns no measurable improvement. The downsampler anti-alias filter is worthwhile and is left in place. Improved coefficients were evaluated for both filters and offer no improvement noticeable in real-world use. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further analysis shows this filter does not provide the benefit originally intended: it costs an additional -4 dB at 3.4 kHz in addition to the transmit filter, and does not appreciably clean up the transmitted signal.
The downsampler anti-alias filter did achieve the expected benefit and remains in place. Improved coefficients were investigated, but did not improve response more than .2dB at the top end – no need to change it.