test(decode): fix Errorf argument order in array-to-struct case#798
Open
Solaris-star wants to merge 1 commit into
Open
test(decode): fix Errorf argument order in array-to-struct case#798Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
TestUnmarshalArrayToStructNoToArrayOptionError swapped the decoded value and error string in t.Errorf, producing misleading failure output. Fixes fxamacker#784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
TestUnmarshalArrayToStructNoToArrayOptionError, thet.Errorfcall for the "want error containing" branch swappederr.Error()andv1.That makes failure messages misleading (and mismatches the format verbs).
Fix
Pass
v1thenerr.Error()to match:Decode(%+v) returned error %q, want error containing %qFixes #784
Test plan
go test -run TestUnmarshalArrayToStruct .