Skip to content

Detect overflow condition for constant addition, subtraction and mult… #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PointsDragon merged 1 commit into from
Aug 1, 2026
Merged

Detect overflow condition for constant addition, subtraction and mult… #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 52 additions & 12 deletions src/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,7 @@ OptimizeIntermediate(COMPSTATE * cstat, int force_err_display)
int *Flags;
unsigned int i;
size_t count = 0;
double tl = 0.0;
int old_instr_count = cstat->nowords;
int AtNo = get_primitive("@");
int BangNo = get_primitive("!");
Expand Down Expand Up @@ -1506,28 +1507,67 @@ OptimizeIntermediate(COMPSTATE * cstat, int force_err_display)
if (curr->next->in.type == PROG_INTEGER) {
/* Int Int + ==> Sum */
if (IntermediateIsPrimitive(curr->next->next, PlusNo)) {
curr->in.data.number += curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
tl = (double)curr->in.data.number + (double)curr->next->in.data.number;
if (!arith_good(tl)) {
if (!(curr->next->next->flags & INTMEDFLG_OVERFLOW)) {
curr->next->next->flags |= INTMEDFLG_OVERFLOW;

if (force_err_display) {
notifyf(cstat->player,
"Warning on line %i: Constant addition leads to overflow",
curr->next->next->in.line);
}
}
} else {
curr->in.data.number += curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
}
break;
}

/* Int Int - ==> Diff */
if (IntermediateIsPrimitive(curr->next->next, MinusNo)) {
curr->in.data.number -= curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
tl = (double)curr->in.data.number - (double)curr->next->in.data.number;
if (!arith_good(tl)) {
if (!(curr->next->next->flags & INTMEDFLG_OVERFLOW)) {
curr->next->next->flags |= INTMEDFLG_OVERFLOW;

if (force_err_display) {
notifyf(cstat->player,
"Warning on line %i: Constant subtraction leads to overflow",
curr->next->next->in.line);
}
}
} else {
curr->in.data.number -= curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
}
break;
}

/* Int Int * ==> Prod */
if (IntermediateIsPrimitive(curr->next->next, MultNo)) {
curr->in.data.number *= curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
tl = (double)curr->in.data.number * (double)curr->next->in.data.number;
if (!arith_good(tl)) {
if (!(curr->next->next->flags & INTMEDFLG_OVERFLOW)) {
curr->next->next->flags |= INTMEDFLG_OVERFLOW;

if (force_err_display) {
notifyf(cstat->player,
"Warning on line %i: Constant multiplication leads to overflow",
curr->next->next->in.line);
}
}
} else {
curr->in.data.number *= curr->next->in.data.number;
RemoveNextIntermediate(cstat, curr);
RemoveNextIntermediate(cstat, curr);
advance = 0;
}
break;
}

Expand Down
Loading