fix(scanner): guard short package tokens in parseApkVersion#2604
Open
arpitjain099 wants to merge 1 commit into
Open
fix(scanner): guard short package tokens in parseApkVersion#2604arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseApkVersionsplits eachapk versionline's package token on-and takestt[:len(tt)-2]as the name. If the token has fewer than two-separators,len(tt)-2is negative and the slice panics (slice bounds out of range), which aborts the whole scan.The two siblings in the same file already guard this:
parseApkInstalledListandparseApkUpgradableListbothcontinueonlen(...) < 3.parseApkVersionwas missing the equivalent check.Repro: an
apk versionline whose name has fewer than two hyphens, e.g.(the header line is skipped by the existing
strings.Contains(line, "<")guard, so only a malformed data line reaches the split.) Before the fix this panics atstrings.Join(tt[:len(tt)-2], ...).This adds the same
len(tt) < 3guard the siblings use.go test ./scanner/passes.