Skip to content

Add suggested words to the user dictionary - #2226

Open
djurcola wants to merge 1 commit into
futo-org:masterfrom
djurcola:agent/add-suggestion-to-dictionary-upstream
Open

Add suggested words to the user dictionary#2226
djurcola wants to merge 1 commit into
futo-org:masterfrom
djurcola:agent/add-suggestion-to-dictionary-upstream

Conversation

@djurcola

Copy link
Copy Markdown

Summary

Adds Add to dictionary to the long-press menu for normal suggested words.

  • Uses the existing Android UserDictionary integration for the active locale.
  • Avoids duplicate no-shortcut entries and refreshes active suggestions after insertion.
  • Keeps Blacklist available for normal suggestions.
  • Preserves the existing emoji menu: Blacklist and Disable emoji suggestions only.

Screenshot

Normal suggested-word long press on device:

Long-press menu with Add to dictionary

Validation

  • git diff --check passed.
  • Resource XML parses successfully.
  • The behavior was exercised in the downstream implementation on a physical Android device.
  • Local Gradle unit testing is blocked before compilation in this environment because no Android SDK is configured; upstream CI is expected to provide the Android build validation.

The screenshot is hosted on a dedicated media-only branch of the contributor fork and is not part of this PR's code diff.

@abb128

abb128 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

I'm not a fan of having this for a few reasons

  1. It makes the menu way more cluttered and confusing. People may misclick on one while trying to do the other
  2. There's already an automatic word learning feature. This pushes people to manually managing word dictionary which is not the recommended way of using the keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants