docs(#5586): add security guidance for destructive forge operations#5587
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#5586): add security guidance for destructive forge operations#5587fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a 'Security considerations for destructive operations' section to docs/contributing/forge-abstraction.md. The section covers three principles for callers of destructive forge methods (close, delete, merge, force-push): verify ownership before acting, prefer fail-closed defaults when authorization data is missing, and guard against predictable-name attacks where external actors could create resources on well-known branch paths. References closeStaleScaffoldPRs in internal/layers/commit.go as a positive example of all three principles. Includes review guidance to flag destructive operations missing authorization checks. Closes #5586
|
🤖 Finished Review · ✅ Success · Started 1:01 AM UTC · Completed 1:11 AM UTC |
Site previewPreview: https://6990d6f8-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR adds documentation to docs/contributing/forge-abstraction.md |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/contributing/forge-abstraction.mdforge.Clientmethods: verify ownership before acting, prefer fail-closed defaults, and guard against predictable-name attackscloseStaleScaffoldPRsininternal/layers/commit.goas a positive example of all three principlesMotivation
PR #5478 added
CloseChangeProposalto the forge interface without authorization checks, requiring a review-fix cycle to add author verification. The forge-abstraction guide had no guidance on security considerations for destructive operations, so the code agent had no signal that such checks were needed.Testing
make lint-md-linkspasses — no broken links introducedCloses #5586
Post-script verification
agent/5586-forge-destructive-ops-guidance)253eb62573e4783735126d34c6283fecde9f0d71..HEAD)