fix(#5465): discover mint URL from org variable for per-org repos#5469
fix(#5465): discover mint URL from org variable for per-org repos#5469fullsend-ai-coder[bot] wants to merge 3 commits into
Conversation
discoverRepo only checked orgCfg.DispatchSettings().MintURL for per-org repos. When the org config had no mint_url in dispatch settings (common for orgs that rely on the FULLSEND_MINT_URL GitHub Actions variable set during admin install), the mint URL was left empty and the generated manifest contained a TODO placeholder. Add a fallback in discoverRepo that checks the org-level GitHub Actions variable FULLSEND_MINT_URL via client.GetOrgVariable() when the org config dispatch settings do not provide a mint URL. The org config remains the primary source; the variable is a best-effort fallback. GetOrgVariable errors are logged as warnings and do not fail discovery. Closes #5465
|
🤖 Review · ❌ Terminated · Started 3:40 PM UTC · Ended 4:03 PM UTC |
Site previewPreview: https://b8a8ad58-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ❌ Failure · Started 3:40 PM UTC · Completed 4:03 PM UTC |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 4:09 PM UTC · Completed 4:23 PM UTC |
ReviewFindingsMedium
Low
Labels: PR modifies internal/repos/ (repos init command — part of the install workflow) |
|
/fs-fix. Rebase and fix all the review issues, both inline and in the sticky comment. Make sure to resolve all the conversations. |
|
/fs-fix - Rebase and fix all the review issues, both inline and in the sticky comment. Make sure to resolve all the conversations. |
|
🤖 Finished Fix · ✅ Success · Started 4:50 PM UTC · Completed 4:56 PM UTC |
- Refactor GetOrgVariable error handling in discoverRepo to use separate declaration and error checks, matching the idiom used elsewhere in the codebase (internal/cli/foreign.go, etc.) - Document org variable fallback in docs/plans/repos-init.md - Document org variable fallback in docs/cli/repos.md discovery section Addresses review feedback on #5469
🔧 Fix agent — iteration 1 (human-triggered)Addressed all 3 review findings: refactored error handling idiom to match codebase convention, and added org variable fallback documentation to both the repos init plan and CLI docs. Fixed (3):
Tests: passed Updated by fullsend fix agent |
Summary
fullsend repos initfails to discover the mint URL for per-org installations whenorgCfg.DispatchSettings().MintURLis empty. This adds a fallback to check the org-level GitHub Actions variableFULLSEND_MINT_URL(set duringfullsend admin install).Related Issue
Fixes #5465
Changes
discoverRepo()(internal/repos/init.go): after checkingorgCfg.DispatchSettings().MintURL, fall back toclient.GetOrgVariable(ctx, owner, "FULLSEND_MINT_URL")when the mint URL is still emptyGetOrgVariableerrors are logged as warnings, not fatalTesting
internal/repostests passTestDiscoverRepo_PerOrg_OrgVarFallback— verifies mint URL is discovered from org variable when org config has no mint_urlTestDiscoverRepo_PerOrg_OrgConfigTakesPrecedence— verifies org config mint_url wins over org variableTestDiscoverRepo_PerOrg_OrgVarError_NonFatal— verifies GetOrgVariable errors produce a warning, not a failurego vetpassesChecklist
!for breaking changes)Closes #5465
Post-script verification
agent/5465-init-mint-url-org-var)8b2146e80c0c8d8dc54fa6fa2b4f5957fc48e602..HEAD)