Normalize Etag format#544
Conversation
nateprewitt
left a comment
There was a problem hiding this comment.
Thanks for the PR, @wonwuakpa-msft, this is a great start! I left some initial feedback on a few things. Please let me know if you think I'm missing something or if you have any questions.
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
|
@wonwuakpa-msft It looks like the latest commit may have modified the newline at the end of spec.py so it's diffing the entire file. Can you take a look at that? Feel free to ping me if you need help. |
2361ebd to
a8249e8
Compare
Yes, it was changing the line endings of every line in spec.py from LF to CRLF, so git detected that as a new change. Setting the |
Description
This fixes a bug with the Etag blob property where
info()andls()were returning different formats. This GitHub issue reproduces said bug. This is due to API differences when usingBlobClient.get_blob_properties()vsBlobContainer.walk_blobs().This PR introduces a standardization to
_details()by ensuring the Etag property return type is wrapped with double quotes. S3fs formats Etags with double quotes hereTest
Added
test_etag_normalized_formto test both calls property is equivalent and there is no double quoting