Fix soundness in ? operator chains via Expr.DynamicChain node#3352
Merged
nojaf merged 2 commits intofsprojects:mainfrom Apr 16, 2026
Merged
Fix soundness in ? operator chains via Expr.DynamicChain node#3352nojaf merged 2 commits intofsprojects:mainfrom
? operator chains via Expr.DynamicChain node#3352nojaf merged 2 commits intofsprojects:mainfrom
Conversation
Two or more chained `?` accesses (e.g. `x?a("")?b(t)`) were formatted
with
a space before each parenthesised argument when SpaceBefore*Invocation
was
enabled. The space changed how the next `?member` was parsed,
producing
code that no longer matched the original AST.
Detect the chain pattern during AST→Oak transformation and represent
it
as a new `Expr.DynamicChain` node. The printer emits the chain tight,
sidestepping the per-call space rule. Lone `?` calls still go through
the existing `Expr.Dynamic` / `Expr.AppSingleParenArg` paths and
continue
to honour `SpaceBefore(Upper|Lower)caseInvocation`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two or more chained
?accesses (e.g.x?a("")?b(t)) were formatted witha space before each parenthesised argument when SpaceBefore*Invocation
was enabled. The space changed how the next
?memberwas parsed,producing code that no longer matched the original AST.
Detect the chain pattern during AST→Oak transformation and represent
it as a new
Expr.DynamicChainnode. The printer emits the chain tight,sidestepping the per-call space rule. Lone
?calls still go throughthe existing
Expr.Dynamic/Expr.AppSingleParenArgpaths andcontinue to honour
SpaceBefore(Upper|Lower)caseInvocation.Fixes #3159