0451-content-01から実装方法の指定を削除#418
Open
ymrl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0451-content-01 で、画像を無視させる方法の指定についての記載が正しくなかった。
aria-label 属性を空にしても、アクセシビリティツリーからは除外されない。
<img>要素であれば alt 属性を空にするか、それ以外の要素(<svg>要素など)ならrole="none"role="presentation"aria-hidden="true"などを指定するなどが指示としては正しい。しかし、そもそも手段ばかりが書かれているが、デザインと実装を切り離しているこのチェックリスト上で重要なのは「この画像は意味をもたないので無視されるべき」を明示することにある。そのため、装飾的な画像であることを明示させるように変更した。