fix(openapi): guard non-struct kind in getContentID ref loop#76
Merged
Alonza0314 merged 2 commits intoJun 22, 2026
Merged
Conversation
Fixes free5gc/free5gc#1040 and free5gc/free5gc#1041. FieldByName and Type().NumField() are only valid on struct kinds. A non-struct value at this point means the ref path resolved to a leaf before all components were consumed. Adding an IsValid+Kind guard at the top of the for loop prevents panics in all three FieldByName call sites within the loop body.
Contributor
Contributor
|
Hi @neelareddybollu, can you help me to trim the comment? |
Contributor
Author
|
Done, trimmed to a single line in the latest commit. Thanks for the feedback! |
Alonza0314
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes free5gc/free5gc#1040 and free5gc/free5gc#1041.
FieldByName and Type().NumField() are only valid on struct kinds. A non-struct value at this point means the ref path resolved to a leaf before all components were consumed. Adding an IsValid+Kind guard at the top of the for loop prevents panics in all three FieldByName call sites within the loop body.