Skip to content

client: fix nil-part panic in MultipartDeserialize on malformed body #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 2 commits into from
Closed

client: fix nil-part panic in MultipartDeserialize on malformed body #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c5c99
client: fix nil-part panic in MultipartDeserialize on malformed body
SAY-5 Apr 23, 2026
11361a5
address review: trim inline comments per maintainer feedback
SAY-5 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,17 +601,20 @@ func MultipartDeserialize(b []byte, v interface{}, boundary string) (err error)
var part, nextPart *multipart.Part
multipartBody := make([]byte, 1400)

// if no remian part, break this loop
if nextPart, err = r.NextPart(); err == io.EOF {
// if no remain part, break this loop
nextPart, err = r.NextPart()
if err == io.EOF {
break
} else {
part = nextPart
}
if err != nil {
return fmt.Errorf("multipart NextPart: %w", err)
}
part = nextPart

contentType := part.Header.Get("Content-Type")
var n int
n, err = part.Read(multipartBody)
if err == nil {
if err != nil && err != io.EOF {
return err
}
multipartBody = multipartBody[:n]
Expand Down