Skip to content

fix(controlplane): guard against empty billing owner emails#2624

Open
mekilis wants to merge 2 commits intomainfrom
smart/billing-email-guardrails
Open

fix(controlplane): guard against empty billing owner emails#2624
mekilis wants to merge 2 commits intomainfrom
smart/billing-email-guardrails

Conversation

@mekilis
Copy link
Copy Markdown
Collaborator

@mekilis mekilis commented Apr 15, 2026

Summary

  • stop Convoy billing sync from sending blank owner emails by short-circuiting when the resolved owner email is empty
  • return a clear 422 response when billing bootstrap cannot resolve organisation owner email
  • add a focused service test that ensures billing create is not called when owner email is empty

Test plan

  • go test ./services -run TestRunBillingOrganisationSync
  • go test ./api/handlers -run \"TestGetInternalOrganisationID_BillingDisabled_DoesNotCallBilling|TestIsBillingOrgNotFound\"

Prevent Convoy from creating billing organisations with blank owner email by short-circuiting sync on empty values and returning a clear 422 when owner email cannot be resolved in billing bootstrap paths.
@mekilis mekilis changed the title fix: guard against empty billing owner emails fix(controlplane): guard against empty billing owner emails Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant