fix(cli): record a submission when no autograder is configured - #535
Merged
Conversation
PR #458 made the grade + set-latest jobs skip entirely when no autograder is configured, which also stopped publishing the submit/* release that records a submission. The submit/* tag was still minted, but the teacher dashboard reads releases, so submissions silently vanished and looked like a bug. Run the grade job for the no-autograder case so runner.py's existing vacuous-pass (0/0 success) result is published as the submit/* release and the submission stays visible. Keep #458's cost win by gating the language-toolchain setup off no-autograder (the recording path needs only system python3). Advance set-latest for the recorded submission too.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #458 made the autograde workflow's
gradeandset-latestjobs skip entirely when an assignment has no autograder configured (no declarative tests, no per-assignment bundle, no classroom-defaultautograder.py). That correctly stopped spending Actions minutes, but it also stopped the side effect that records a submission: thesubmit/*GitHub Release. Thesubmit/*tag was still minted in thesetupjob, but the teacher submissions dashboard reads Releases (vialatestSubmitReleaseAndCount), not tags — so a student who pushed to a no-autograder assignment silently vanished from the teacher's view and it read like a bug.This restores the "records" half while keeping #458's cost win. The
gradejob now runs for the no-autograder case sorunner.py's existing vacuous-pass path (Finalizer.no_autograder()) synthesizes aresult.jsonscoring 0/0 withstatus=success, which the existing "Publish submission release" step publishes as thesubmit/*release. Language-toolchain setup (Python/Node/Java/Go/Rust + apt) is gated offno-autograder, so the recording path provisions no toolchain it won't use — it needs only systempython3.This is forward-compatible with the "milestone tags trigger;
submit/*records" invariant reaffirmed in the draft PR #531:submit/*stays the canonical record channel.Changes
grade.ifnow gates only on the acceptance commit; the no-autograder clause is dropped so the job runs and records the submission.&& needs.setup.outputs.no-autograder != 'true', preserving the feat(cli): skip autograde grade job when no autograder is configured #458 minute savings.always()"Post commit status" step already postsclassroom50/autograde=successwith the runner's "no autograder configured" summary, so the status-polling channel is at parity with no double-post.set-latestdrops itsno-autograderguard so the recorded submission advances the latest pointer.init_skeleton_test.goparity assertions (the pinnedgrade.ifstring and the six toolchainif:strings) and a stale comment intest_inline_validator.py. Norunner.pylogic change — its no-autograder synthesis was already correct and covered.Verification
go test ./...incli/gh-teacherpasses, includingTestSkeletonFiles_AutogradeRunner;go vetandgofmtclean.python3 -m pytest cli/gh-teacher/autograders_tests— 358 pass, includingtest_no_bundle_and_no_default_synthesizes_vacuous_pass, which pins the end-to-end 0/0-success recording (result.json, release body,status=success).setup/grade/set-latest(no job added).